From ff3ac68d159869d57e2cc190236d08c64e00b867 Mon Sep 17 00:00:00 2001 From: Jonas Maier <> Date: Tue, 10 Mar 2026 17:53:01 +0100 Subject: some clippy warnings --- src/run/mod.rs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'src/run/mod.rs') diff --git a/src/run/mod.rs b/src/run/mod.rs index c7f4408..6234b96 100644 --- a/src/run/mod.rs +++ b/src/run/mod.rs @@ -49,7 +49,7 @@ impl ExecError { e => format!("I am surprised you can get this error here: {e:?}"), }, ExecError::IO(error) => format!("{error:?}"), - ExecError::Panic => format!("worker thread panicked"), + ExecError::Panic => String::from("worker thread panicked"), ExecError::ErrorStack(stack) => { let mut out = String::new(); for e in stack.iter() { @@ -98,9 +98,9 @@ pub enum Output { File(File), } -impl Into for Input { - fn into(self) -> Stdio { - match self { +impl From for Stdio { + fn from(value: Input) -> Self { + match value { Input::Stdin => Stdio::inherit(), Input::Pipe(reader) => reader.into(), Input::File(file) => file.into(), @@ -108,9 +108,9 @@ impl Into for Input { } } -impl Into for Output { - fn into(self) -> Stdio { - match self { +impl From for Stdio { + fn from(value: Output) -> Stdio { + match value { Output::Stdout => Stdio::inherit(), Output::Pipe(writer) => writer.into(), Output::File(file) => file.into(), @@ -399,7 +399,7 @@ pub fn run(se: Arc>, cmd: Vec) { Ok(p) => p, Err(err) => { se.lock().unwrap().raw.disable(); - println!("{:?}: {}", err.0, String::from_utf8_lossy(&err.1)); + println!("{:?}: {}", err.0, String::from_utf8_lossy(err.1)); print!("{}", se.lock().unwrap().prompt()); std::io::stdout().lock().flush().unwrap(); se.lock().unwrap().raw.enable(); -- cgit v1.2.3