some clippy warnings

1 files changed, 8 insertions, 8 deletions

diff --git a/src/run/mod.rs b/src/run/mod.rs
index c7f4408..6234b96 100644
--- a/src/run/mod.rs
+++ b/src/run/mod.rs
@@ -49,7 +49,7 @@ impl ExecError {
                 e => format!("I am surprised you can get this error here: {e:?}"),
             },
             ExecError::IO(error) => format!("{error:?}"),
-            ExecError::Panic => format!("worker thread panicked"),
+            ExecError::Panic => String::from("worker thread panicked"),
             ExecError::ErrorStack(stack) => {
                 let mut out = String::new();
                 for e in stack.iter() {
@@ -98,9 +98,9 @@ pub enum Output {
     File(File),
 }
 
-impl Into<Stdio> for Input {
-    fn into(self) -> Stdio {
-        match self {
+impl From<Input> for Stdio {
+    fn from(value: Input) -> Self {
+        match value {
             Input::Stdin => Stdio::inherit(),
             Input::Pipe(reader) => reader.into(),
             Input::File(file) => file.into(),
@@ -108,9 +108,9 @@ impl Into<Stdio> for Input {
     }
 }
 
-impl Into<Stdio> for Output {
-    fn into(self) -> Stdio {
-        match self {
+impl From<Output> for Stdio {
+    fn from(value: Output) -> Stdio {
+        match value {
             Output::Stdout => Stdio::inherit(),
             Output::Pipe(writer) => writer.into(),
             Output::File(file) => file.into(),
@@ -399,7 +399,7 @@ pub fn run(se: Arc<Mutex<Session>>, cmd: Vec<u8>) {
         Ok(p) => p,
         Err(err) => {
             se.lock().unwrap().raw.disable();
-            println!("{:?}: {}", err.0, String::from_utf8_lossy(&err.1));
+            println!("{:?}: {}", err.0, String::from_utf8_lossy(err.1));
             print!("{}", se.lock().unwrap().prompt());
             std::io::stdout().lock().flush().unwrap();
             se.lock().unwrap().raw.enable();